Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation fix #117

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

romatroskin
Copy link

Fixed rotation and minor updates of libraries build tools and gradle plugin, also min sdk version is 14 now

@eriknyk
Copy link

eriknyk commented Oct 5, 2018

can we this PR merged?, rotation should be fixed..

@eriknyk
Copy link

eriknyk commented Oct 5, 2018

Hi @romatroskin I've tried you PR with rotation fixes,
I think it is pretty good!, however after rotate the image is being scaled, what is good,
however the pad area to continue signing is being cropped also, and the result s that we had unusable half space.

initial

image

after rotate to landscape

image

the usable area is only the green rectangle, the rest os unusable space

screenshot_20181005-160937

@vintrecenio
Copy link

Following up on this issue on rotation fix. Any updates on this? Still the issue is when you rotate the device to landscape, only the left portion of the screen is usable to write your signature on, other half is useless as mentioned by @eriknyk .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants