Idiomatic Error Handling #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace argparse library with clap - Consolidate input validation into single method in Cli impl - Refactor error handling by introducing CliError and NetUtilsError enums - Implement Display trait for better error output - Altered output formatting for to separate info from action - Update function signatures to better reflect the types of errors they can return Breaking Change: - Update main function signature to return Result<(), NetUtilsError> - Argument variable names TODO: - Add more error handling in arp.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I really liked your project and had some fun today adding more structured error handling and input validation. Moved all the error related stuff to a new file called error.rs to make it easier to add to it. Didn't even touch arp.rs, but I will do that next and will also see about making this tool compatible with Windows.
Obviously you don't have to accept the pull request, but either way good work on this!