Gh 137 test built images cherry pick #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t92549
commented
Mar 29, 2022
ctas582
reviewed
Mar 30, 2022
There was a problem hiding this comment.
Should we refactor the pom in gaffer-operation-runner so that the gaffer version is a property?:
and then pass in the gaffer version we want to build the container against here?:
otherwise we will have to remember to manually bump the version in the pom if there's a breaking change
t92549
commented
Mar 30, 2022
t92549
commented
Mar 30, 2022
ctas582
approved these changes
Mar 31, 2022
t92549
commented
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked relevant commits from #138 with updated develop
Related Issue