Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event polling code. #667

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Refactor event polling code. #667

merged 1 commit into from
Dec 8, 2023

Conversation

gdamore
Copy link
Owner

@gdamore gdamore commented Dec 8, 2023

This centralizes much of the logic (hopefully reducing duplication) for polling events and the queue. This will make it easier to make further design changes to express a better, simpler, API to consumers.

While here addressed missing logic to handle Fini correctly on Windows.

This centralizes much of the logic (hopefully reducing duplication)
for polling events and the queue.  This will make it easier to make
further design changes to express a better, simpler, API to consumers.

While here addressed missing logic to handle Fini correctly on Windows.
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (e3a99dd) 45.58% compared to head (28c7846) 45.80%.

Files Patch % Lines
console_win.go 0.00% 22 Missing ⚠️
screen.go 45.45% 18 Missing ⚠️
tscreen.go 0.00% 15 Missing ⚠️
simulation.go 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   45.58%   45.80%   +0.22%     
==========================================
  Files          79       79              
  Lines        8314     8280      -34     
==========================================
+ Hits         3790     3793       +3     
+ Misses       4495     4458      -37     
  Partials       29       29              
Flag Coverage Δ
unittests 45.80% <25.60%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 8041b8e into main Dec 8, 2023
5 of 6 checks passed
@gdamore gdamore deleted the gdamore/eventq branch December 8, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant