Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed package attribute and add namespace property #130

Closed
wants to merge 1 commit into from

Conversation

tattuu
Copy link
Contributor

@tattuu tattuu commented Jan 5, 2024

The content written in this issue (#86) seems to have occurred due to the Android Gradle Plugin(AGP) version being 8 or higher.

Therefore, I have made changes to adapt to Gradle 8 and above.

Reference Materials:

  1. AGP version 8.0.0 doesn't work with Capacitor ionic-team/capacitor#6504
  2. https://bps-tomoya.hateblo.jp/entry/2022/05/11/193325
  3. https://developer.android.com/studio/build/configure-app-module?hl=ja#set-namespace

@gdelataillade
Copy link
Owner

Hi @tattuu

Thanks for your PR !

Unfortunately, I tested my alarm example app with your changes and alarms did not trigger... Is there something more to change ? Looks like my native services were not found. No error logs in the debug console.

@gdelataillade
Copy link
Owner

What Gradle version and what Java version are you using ?

@tattuu tattuu closed this Jan 21, 2024
@tattuu tattuu deleted the fix/gradle8-support branch January 21, 2024 17:33
@tattuu tattuu mentioned this pull request Jan 21, 2024
@tattuu
Copy link
Contributor Author

tattuu commented Jan 21, 2024

Hi @gdelataillade

I apologize for the delayed response.

I've created a new pull request (#139) that includes the modifications in the 'example' directory and addresses several missing commits from the previous submission.

I generated the pull request based on the latest state of the main branch and have already conducted testing to ensure functionality.

I appreciate your multiple reviews, and I apologize for any inconvenience.

If you could please check the latest pull request, I would be grateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants