Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature -> Add notification action buttons (stop) #223

Merged
merged 14 commits into from
Aug 30, 2024

Conversation

gdelataillade
Copy link
Owner

@gdelataillade gdelataillade commented Jul 15, 2024

Tasks:

  • Implement iOS stop
  • Implement Android stop
  • Tests on iOS
  • Tests on Android <12
  • Tests on Android 12+
  • Review & clean code
  • Add documentation
  • Update README

Note: Snooze will not work on iOS if app was killed.

TODO: Notify contributors when version 4 is published.

@gdelataillade gdelataillade added the work in progress This issue is being worked on label Jul 15, 2024
@gdelataillade gdelataillade self-assigned this Jul 15, 2024
@gdelataillade gdelataillade force-pushed the feat/notification-action-buttons branch from f342290 to 9ba0411 Compare July 15, 2024 16:06
@nafiskabbo
Copy link

nafiskabbo commented Aug 1, 2024

I need this feature because currently custom sounds cannot be stopped. When will it be pushed?

@gdelataillade
Copy link
Owner Author

gdelataillade commented Aug 2, 2024

I need this feature because currently custom sounds cannot be stopped. When will it be pushed?

@nafiskabbo Give me a couple of weeks. I'm about to finish it but then I'll need to do a lot of testing.
If you are willing to help me test it will be faster.

@gdelataillade gdelataillade changed the title Feature -> Add notification action buttons (stop & snooze) Feature -> Add notification action buttons (stop) Aug 7, 2024
Copy link
Owner Author

@gdelataillade gdelataillade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Nulinz
Copy link

Nulinz commented Aug 27, 2024

how to use 4.0.0-dev.1 or view the code of 4.0.0-dev.1 ?? when it should be released

@gdelataillade
Copy link
Owner Author

Hi @Nulinz

To use this PR just set version 4.0.0-dev.2 in your pubspec. Stable version should be released very soon when I finish fixing some minor issues. Let me know if you find any.

@gdelataillade gdelataillade merged commit 000c605 into main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress This issue is being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants