Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for fadeDuration and isRinging to example app #272

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add tests for fadeDuration and isRinging to example app #272

merged 2 commits into from
Oct 29, 2024

Conversation

orkun1675
Copy link
Contributor

@orkun1675 orkun1675 commented Oct 29, 2024 •
edited
Loading

gdelataillade
gdelataillade approved these changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@gdelataillade gdelataillade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdelataillade gdelataillade merged commit 13cedf6 into gdelataillade:main Oct 29, 2024
1 check passed
@gdelataillade
Copy link
Owner

Thanks @orkun1675

@gdelataillade
Copy link
Owner

@orkun1675 I have been experimenting with the example app and I sometimes have a dark screen when I stop the alarm, like navigation popped twice.

@orkun1675
Copy link
Contributor Author

orkun1675 commented Nov 2, 2024 •
edited
Loading

@gdelataillade my new PR addresses that issue by delegating popping the route to the isAlarmRining listener. See changes here: https://github.com/gdelataillade/alarm/pull/276/files#diff-00e21ecc08249d9a653eb5404d795049cd40298d41930d9e140d3796d143b423R53

The Snooze/Stop buttons no longer pop the route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdelataillade gdelataillade gdelataillade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orkun1675 @gdelataillade