Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Use triggerTime to determine if alarm is ringing #283

Merged
merged 13 commits into from
Dec 10, 2024

Conversation

orkun1675
Copy link
Contributor

@orkun1675 orkun1675 commented Nov 11, 2024

Fixes #265

ios/Classes/SwiftAlarmPlugin.swift Outdated Show resolved Hide resolved
ios/Classes/SwiftAlarmPlugin.swift Outdated Show resolved Hide resolved
@gdelataillade gdelataillade added the reviewing This PR is being reviewed label Nov 12, 2024
@orkun1675
Copy link
Contributor Author

Please see the latest commit (7caa021) for the diffs.

@orkun1675 orkun1675 changed the title Use triggerTime to determine if alarm is ringing [iOS] Use triggerTime to determine if alarm is ringing Dec 8, 2024
Copy link
Owner

@gdelataillade gdelataillade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdelataillade gdelataillade merged commit 7b9dde5 into gdelataillade:main Dec 10, 2024
1 check passed
@orkun1675 orkun1675 deleted the isringing-fix branch December 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewing This PR is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: Alarm.isRinging(alarmId) is FALSE after alarm rings
2 participants