-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix: Alarm rings NOW in DateTime.now (in a difference of 1 sec) #68
[Android] Fix: Alarm rings NOW in DateTime.now (in a difference of 1 sec) #68
Conversation
Hi @dtkdt100, Your added code will only run when the alarm is set to sound at the precise moment it is activated. Is this what you want ? What's the use case ? |
@gdelataillade For me the use case is: Also, in your example app there is a button for "Ring now", so I tought if it is in your example app it must be used for something |
Hi @dtkdt100, OK I see. The NOW button in the example is to show the proof-of-concept. |
Did you make some tests ? Your code works good ? |
@gdelataillade Yes. Tests:
|
Does your GPS app has to ring even if the app is on background ? |
Indeed. |
With the code you added, are you sure the alarm will ring in the background ? Because the point of using |
Yes it is working for me. But i am not sure if it is because of But in this case there is not option that the phone will be in background because when you start the alarm the app will be in foreground, the alarm rings immediately |
OK cool, then give me a few days to run some tests and take a look at Thanks for your work. |
Thanks for your quick response! |
@gdelataillade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Merged to main branch ! Thanks for your contribution ! |
FIx (#66)
Before:
screen-20230721-104006.mp4
After
screen-20230721-104628.mp4