fix: CD workflow에서 환경변수가 제대로 설정되지 않던 문제 해결

gdsc-konkuk · Jan 27, 2024 · 96c3aa6 · 96c3aa6
1 parent a044ad2
commit 96c3aa6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/.github/ISSUE_TEMPLATE/1-FEAT.md b/.github/ISSUE_TEMPLATE/1-FEAT.md
@@ -2,7 +2,7 @@
 name: Feature Request
 about: 기능 구현 요청
 description: 새로운 기능 구현
-title: "[Feat]: ~~"
+title: "[Feat] ~~"
 labels: "🚀 기능 구현 🚀"
 assignees: ''
 

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -15,7 +15,6 @@
 
 ### 등록 전 확인
 
-- [ ] 모든 test가 pass했나요?
 - [ ] 모든 code가 well-formatted인가요?
 - [ ] commit message는 직관적이었을까요?
 - [ ] 삭제해야 할, 주석처리 된 코드는 없을까요?
diff --git a/.github/workflows/Continuous Delivery.yml b/.github/workflows/Continuous Delivery.yml
@@ -9,11 +9,6 @@ jobs:
   Delivery:
     runs-on: ubuntu-22.04
 
-    env:
-      DB_URL: ${{ secrets.DB_URL }}
-      DB_USER: ${{ secrets.DB_USR }}
-      DB_PASSWORD: ${{ secrets.DB_PWD }}
-
     steps:
       - name: Set up sources
         uses: actions/checkout@v4
@@ -33,6 +28,10 @@ jobs:
 
       - name: Execute Gradle build
         run: ./gradlew build
+        env:
+          DB_URL: ${{ secrets.DB_URL }}
+          DB_USER: ${{ secrets.DB_USR }}
+          DB_PASSWORD: ${{ secrets.DB_PWD }}
 
       - name: Login to docker-hub
         uses: docker/login-action@v3

diff --git a/.github/workflows/Continuous Integration.yml b/.github/workflows/Continuous Integration.yml
@@ -9,11 +9,6 @@ jobs:
   Test:
     runs-on: ubuntu-22.04
 
-    env:
-      DB_URL: ${{ secrets.DB_URL }}
-      DB_USER: ${{ secrets.DB_USR }}
-      DB_PASSWORD: ${{ secrets.DB_PWD }}
-
     steps:
       - name: Set up sources
         uses: actions/checkout@v4