Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

[Fix] Photo url #36 #37

Merged
merged 4 commits into from
Jan 24, 2024
Merged

[Fix] Photo url #36 #37

merged 4 commits into from
Jan 24, 2024

Conversation

zbqmgldjfh
Copy link
Member

@zbqmgldjfh zbqmgldjfh commented Jan 24, 2024

개요

  1. 사진 저장 URL 부분 수정
  2. 아예 멀티파트 폼 최대 25MB로 제한
  3. ExceptionHandler 구현

논의가 필요한 사항

KakaoTalk_Photo_2024-01-24-15-27-02

로컬에 저장후 생성된 경로가, URL 도메인 검증에서 예외 발생시키는중 (정상적으로 발생한 건전한 예외)
향후 Cloud 로 이전시 사진 저장 URL을 수정해줘야 함

등록 전 확인

  • 모든 test가 pass했나요?
  • 모든 code가 well-formatted인가요?
  • commit message는 직관적이었을까요?
  • 삭제해야 할, 주석처리 된 코드는 없을까요? --> 일부러 남겨둔 TODO 주석이 있습니다!

@zbqmgldjfh zbqmgldjfh added the 🚨 심각한 버그 🚨 심각한 버그 label Jan 24, 2024
@zbqmgldjfh zbqmgldjfh self-assigned this Jan 24, 2024
Copy link
Collaborator

@goldentrash goldentrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@zbqmgldjfh zbqmgldjfh merged commit 191e6fa into develop Jan 24, 2024
1 check passed
@goldentrash goldentrash deleted the fix/photo-url-#36 branch January 25, 2024 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants