This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
[Feat] RECORDING hsitory 직접 추가 방지
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zbqmgldjfh
suggested changes
Jan 25, 2024
| @@ -60,6 +60,9 @@ class PlantService( | |||
| val findMember = memberRepository.findByDeviceTokenOrThrow(deviceToken) | |||
| val findCompanionPlant = companionPlantRepository.findByIdAndMemberIdOrThrow(plantId, findMember.getId) | |||
|
|
|||
| if (historyType == HistoryType.RECORDING) | |||
There was a problem hiding this comment.
음! 객체지향적으로 조금만 더 생각해봅시다!! 토끼책 읽어줘여어어어!
추가로 if()문 뒤에 한줄 쓰더라고 {} 중괄호 사용하셔야 됩니다.
Google Java Guide Docs 참고해보시길
zbqmgldjfh
suggested changes
Jan 25, 2024
There was a problem hiding this comment.
https://newwisdom.tistory.com/96 Java 스타일 가이드도 눈으로 한번 쓱 보면 도움 많이될거에요!!
zbqmgldjfh
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
히스토리 추가 API를 통해 데일리 기록 히스토리 추가를 방지 (close #33)
Todo
PlantService테스트 작성PlantService.createHistory가RECORDING직접 등록 방지하도록 변경웃픈(?) 이야기
데일리 기록 히스토리 직접 추가는 곁가지고, 물줬을때 날짜 갱신이 메인인데, 이거 이미 구현되어있던 기능이네요
착각했던... ㅠ
등록 전 확인