This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
[Feat] 식물 정보 조회 API #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
zbqmgldjfh
suggested changes
Jan 25, 2024
| """ | ||
| SELECT new gdsc.plantory.plantInformation.presentation.dto.PlantInformationDto( | ||
| pi.id, | ||
| pi.imageUrl._value, |
There was a problem hiding this comment.
저희 전체 조회에서 이미지가 필요할까요??
현 모델에서는 이름과 id만 반환해줘도 충분할 것 같아서요!!
| FROM PlantInformation pi | ||
| """ | ||
| ) | ||
| fun findAllProjected(): List<PlantInformationDto> |
There was a problem hiding this comment.
혹시 이름이 왜 Projected인가요?? 이 메서드 이름만 보고는 왜 전체 식물 정보가 조회되는지 모르겠습니다?
| .get("/api/v1/plantInformations") | ||
| .then() | ||
| .log().all() | ||
| .statusCode(HttpStatus.OK.value()) |
There was a problem hiding this comment.
HttpStatus 검증은 여기서 빼도 될것 같아요!! 확인쪽에서 검증해주고 있어서요!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
식물 정보 조회 API 구현 (close #39)
Todo
PlantInformationAcceptance테스트 작성PlantInformationQueryApi구현등록 전 확인