Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh formats and shader adaptation tests #232

Merged
merged 23 commits into from
Feb 15, 2018

Conversation

ragner
Copy link
Contributor

@ragner ragner commented Jan 30, 2018

  • Mesh formats and shader combination tests
  • Shader adaptation tests
  • New utils class GVRSceneMaker to create GVRScene from JSON format

We need help with some known issues:

  1. Fix for: Shader type is always invalid Samsung/GearVRf#1717 because we have to check material type at our JSON parser.

  2. Help to create the right screenshot with the expected results and upload them to github.

  3. meshFormatsWithShaderCombinationsTest() :

    • Screenshot of meshes without textures but with color doesn't work.
    • Help to create the expected screenshots for each combination.
  4. meshWithoutLightingTest():

    • GVRf looks not working as expected after add the lighting.
  5. meshSwitchTexcoordSet():

    • GVRf looks not working as expected after change the textcoords.

GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes [email protected]
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto [email protected]
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva [email protected]
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay [email protected]

ragner and others added 6 commits January 30, 2018 13:27
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
* Add GVRSceneMaker class to create a scene from a json string
* Add RGBAColor class to represent a rgba color.

GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
* Add some convenience function to parse json arrays
of int and float

GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
@ragner ragner force-pushed the feature_rendershader_tests branch from 4330a76 to dcfa259 Compare January 30, 2018 22:21
eliamara and others added 17 commits February 2, 2018 19:29
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
SIDIA #openSource analysis

GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
@ragner ragner force-pushed the feature_rendershader_tests branch from dcfa259 to 85ef188 Compare February 2, 2018 23:31
@ragner ragner mentioned this pull request Feb 9, 2018
@liaxim
Copy link
Collaborator

liaxim commented Feb 13, 2018

meshStartWithtTextureTest crashes always for me. Probably a gvrf bug.

Golden masters missing. Could you add some for couple of phones?

@liaxim
Copy link
Collaborator

liaxim commented Feb 13, 2018

obj.getRenderData().getMaterial().setMainTexture(null); leads to a crash in gvrf. The null must propagate to c++ and the pointer cleared. The Java texture object gets gc-ed (no strong ref to it), takes down the c++ object but we still have a pointer to it in shaderdata.

@liaxim
Copy link
Collaborator

liaxim commented Feb 13, 2018

meshWithoutLightingTest leads to another crash too. Looks like a problem in the Samsung/GearVRf#1737 pull request I am using. Good tests.

@NolaDonato
Copy link
Collaborator

When I run these tests individually they all work. Running them as a group crashes frequently (I am using PR #1743 to run them)

@liaxim
Copy link
Collaborator

liaxim commented Feb 14, 2018

Planning to merge on Thursday and continue fixing the crashes. There is no fault in the test code from what I can tell. Some of the crashes have been fixed by pending pull requests for the framework.

@liaxim liaxim merged commit 2d8ced9 into gearvrf:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants