-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh formats and shader adaptation tests #232
Conversation
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
* Add GVRSceneMaker class to create a scene from a json string * Add RGBAColor class to represent a rgba color. GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
* Add some convenience function to parse json arrays of int and float GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
4330a76
to
dcfa259
Compare
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto <[email protected]> GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay <[email protected]>
SIDIA #openSource analysis GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes <[email protected]>
dcfa259
to
85ef188
Compare
meshStartWithtTextureTest crashes always for me. Probably a gvrf bug. Golden masters missing. Could you add some for couple of phones? |
|
meshWithoutLightingTest leads to another crash too. Looks like a problem in the Samsung/GearVRf#1737 pull request I am using. Good tests. |
When I run these tests individually they all work. Running them as a group crashes frequently (I am using PR #1743 to run them) |
Planning to merge on Thursday and continue fixing the crashes. There is no fault in the test code from what I can tell. Some of the crashes have been fixed by pending pull requests for the framework. |
We need help with some known issues:
Fix for: Shader type is always invalid Samsung/GearVRf#1717 because we have to check material type at our JSON parser.
Help to create the right screenshot with the expected results and upload them to github.
meshFormatsWithShaderCombinationsTest() :
meshWithoutLightingTest():
meshSwitchTexcoordSet():
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes [email protected]
GearVRf-DCO-1.0-Signed-off-by: Cristiano Bozzetto [email protected]
GearVRf-DCO-1.0-Signed-off-by: Eliamara Silva [email protected]
GearVRf-DCO-1.0-Signed-off-by: Diego Azulay [email protected]