Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same fct call for cwd and annmax #2

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

fabern
Copy link
Member

@fabern fabern commented Aug 20, 2024

Following the DRY principle ("don't repeat yourself") this pull request streamlines the code (and hopefully reduces code complexity). It does so by defining a single, generic function apply_fct_to_each_file() for the operations that previously used a separate cwd_byLON() and cwd_annmax_byilon().

Potentially this could also be used in the grsofun package.

The function apply_fct_to_each_file() will need to be extended, once the cwd() function is further developed and needs to load two data.frames from .rds-files.

@fabern fabern force-pushed the use-same-fct-call-for-CWD-and-ANNMAX branch from 30922c4 to 6bfa25b Compare August 26, 2024 07:36
@stineb stineb marked this pull request as ready for review September 2, 2024 07:30
@stineb stineb merged commit 5cfd51b into main Sep 2, 2024
1 check passed
@stineb stineb deleted the use-same-fct-call-for-CWD-and-ANNMAX branch September 2, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants