Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BiomeE likelihood for calibration with a) multiple targets and b) multiple sites #233

Closed
wants to merge 21 commits into from

Conversation

fabern
Copy link
Member

@fabern fabern commented Oct 22, 2024

BiomeE likelihood function was very basic, mainly a hardcoded proof-of-concept but not flexible enough to apply to multiple sites or multiple target variables.
This PR updates this.

This PR further serves as a opportunity to streamline the likelihoods/RMSE calculations and properly applying the DRY principle (reducing the repeated code).

  • add tests for current behavior
  • homogenize likelihoods for p-model and BiomeE-model
  • split likelihood function in
    • a first part that runs the model and generates an obs_pred_data.frame
      • TODO: streamline pred_obs result from likelihoodHelper_combine_model_obs() into a single, long data.frame()
    • and a second part that computes RMSE/likelihood/GoF between obs and pred
  • same as above for RMSE functions, too
  • add argument verbose=FALSE from PR: Minor changes #217
  • update vignettes, tests etc. with the split-function-approach

This is not only relevant for BiomeE but also changing the calibration of p-model to use ET instead/in addition to GPP. Hence this is also related to: geco-bern/sofunCalVal#5 and geco-bern/sofunCalVal#17

@fabern fabern changed the title Enabale BiomeE likelihood for multi target calibration Enable BiomeE likelihood for multi target calibration Oct 22, 2024
@fabern fabern changed the title Enable BiomeE likelihood for multi target calibration Enable BiomeE likelihood for calibration with a) multiple targets and b) mutliple sites Oct 22, 2024
@fabern fabern changed the title Enable BiomeE likelihood for calibration with a) multiple targets and b) mutliple sites Enable BiomeE likelihood for calibration with a) multiple targets and b) multiple sites Oct 22, 2024
@fabern fabern self-assigned this Oct 22, 2024
@fabern fabern closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant