Objects movements

gecoscc/api/__init__.py

@@ -28,13 +28,13 @@
 from gecoscc.tasks import object_created, object_changed, object_deleted, object_moved
 from gecoscc.utils import (get_computer_of_user, get_filter_nodes_parents_ou,
                            oids_filter, check_unique_node_name_by_type_at_domain,
-                           visibility_object_related, visibility_group)
-
+                           visibility_object_related, visibility_group,
+                           RESOURCES_EMITTERS_TYPES, get_object_related_list)
 from gecoscc.i18n import gettext as _
-                           
+
 import logging
 logger = logging.getLogger(__name__)
-                           
+
 SAFE_METHODS = ('GET', 'OPTIONS', 'HEAD',)
 UNSAFE_METHODS = ('POST', 'PUT', 'PATCH', 'DELETE', )
 SCHEMA_METHODS = ('POST', 'PUT', )
@@ -179,8 +179,15 @@ def get(self):
         node = self.collection.find_one(collection_filter)
         if not node:
             raise HTTPNotFound()
+        node = self.parse_item(node)
+        if node.get('type', None) in RESOURCES_EMITTERS_TYPES:
+            node['is_assigned'] = self.is_assigned(node)
+            return node
+        return node
 
-        return self.parse_item(node)
+    def is_assigned(self, related_object):
+        node_with_related_object = get_object_related_list(self.request.db, related_object)
+        return bool(node_with_related_object.count())
 
 
 class ResourcePaginated(ResourcePaginatedReadOnly):
@@ -202,17 +209,17 @@ def integrity_validation(self, obj, real_obj=None):
     def pre_save(self, obj, old_obj=None):
         if old_obj and 'name' in old_obj:
             obj['name'] = old_obj['name']
-        
+
         # Check he policies "object_related_list" attribute
         if 'policies' in obj:
             policies = obj['policies']
             for policy in policies:
                 # Get the policy
                 policyobj = self.request.db.policies.find_one({"_id": ObjectId(str(policy))})
                 if policyobj is None:
-                    logger.warning("Unknown policy: %s"%(str(policy)))
+                    logger.warning("Unknown policy: %s" % (str(policy)))
                 else:
-                    # Get the related object collection 
+                    # Get the related object collection
                     ro_collection = None
                     if policyobj['slug'] == 'printer_can_view':
                         ro_collection = self.request.db.nodes
@@ -225,22 +232,21 @@ def pre_save(self, obj, old_obj=None):
                     elif policyobj['slug'] == 'package_profile_res':
                         ro_collection = self.request.db.software_profiles
                     else:
-                        logger.warning("Unrecognized slug: %s"%(str(policyobj['slug'])))
-                        
+                        logger.warning("Unrecognized slug: %s" % (str(policyobj['slug'])))
+
                     # Check the related objects
                     if ro_collection is not None:
                         ro_list = policies[str(policy)]['object_related_list']
                         for ro_id in ro_list:
                             ro_obj = ro_collection.find_one({"_id": ObjectId(str(ro_id))})
                             if ro_obj is None:
-                                logger.error("Can't find related object: %s:%s"%(str(policyobj['slug']), str(ro_id)))
-                                self.request.errors.add('body', 'object', "Can't find related object: %s:%s"%(str(policyobj['slug']), str(ro_id)))
+                                logger.error("Can't find related object: %s:%s" % (str(policyobj['slug']), str(ro_id)))
+                                self.request.errors.add('body', 'object', "Can't find related object: %s:%s" % (str(policyobj['slug']), str(ro_id)))
                                 return None
-
-
+
         else:
             logger.debug("No policies in this object")
-            
+
         return obj
 
     def post_save(self, obj, old_obj=None):
@@ -386,9 +392,8 @@ class TreeResourcePaginated(ResourcePaginated):
     def check_unique_node_name_by_type_at_domain(self, obj):
         unique = check_unique_node_name_by_type_at_domain(self.request.db.nodes, obj)
         if not unique:
-            self.request.errors.add(
-                        'body', 'name',
-                        "Name must be unique in domain.")
+            self.request.errors.add('body', 'name',
+                                    "Name must be unique in domain.")
         return unique
 
     def integrity_validation(self, obj, real_obj=None):
@@ -446,24 +451,28 @@ def check_memberof_integrity(self, obj):
                 return False
         return True
 
-    def check_policies_integrity(self, obj):
+    def check_policies_integrity(self, obj, is_moved=False):
         """
         Check if the policie is out of scope
         """
         obj_original = deepcopy(obj)
         visibility_object_related(self.request.db, obj)
-        if obj != obj_original:
-            self.request.errors.add(unicode(obj[self.key]), 'policies',
-                                    "The related object is out of scope")
-            return False
+        if not is_moved:
+            if obj != obj_original:
+                self.request.errors.add(unicode(obj[self.key]), 'policies',
+                                        "The related object is out of scope")
+                return False
         return True
 
     def integrity_validation(self, obj, real_obj=None):
         result = super(TreeLeafResourcePaginated, self).integrity_validation(
             obj, real_obj)
         result = result and self.check_memberof_integrity(obj)
-        result = result and self.check_policies_integrity(obj)
         result = result and self.check_unique_node_name_by_type_at_domain(obj)
+        if real_obj is not None and real_obj['path'] == obj['path']:
+            result = result and self.check_policies_integrity(obj)
+        else:
+            result = result and self.check_policies_integrity(obj, is_moved=True)
         return result
 
     def computers_to_group(self, obj):
@@ -527,3 +536,37 @@ def get_objects_filter(self):
             filters.append({'path': get_filter_nodes_parents_ou(self.request.db,
                                                                 ou_id, item_id)})
         return filters
+
+    def check_obj_is_related(self, obj):
+        '''
+        Check if the emitter object is related with any object
+        '''
+        if obj.get('_id'):
+            if obj['type'] == 'printer':
+                slug = 'printer_can_view'
+            elif obj['type'] == 'repository':
+                slug = 'repository_can_view'
+            elif obj['type'] == 'storage':
+                slug = 'storage_can_view'
+            elif obj['type'] == 'group':
+                members_group = obj['members']
+                if not members_group:
+                    return True
+                return False
+
+            policy_id = self.request.db.policies.find_one({'slug': slug}).get('_id')
+            nodes_related_with_obj = self.request.db.nodes.find({"policies.%s.object_related_list"
+                                                                % unicode(policy_id): {'$in': [unicode(obj['_id'])]}})
+
+            if nodes_related_with_obj.count() == 0:
+                return True
+
+            return False
+        return True
+
+    def integrity_validation(self, obj, real_obj=None):
+        result = super(PassiveResourcePaginated, self).integrity_validation(
+            obj, real_obj)
+        result = result and (self.request.user.get('is_superuser', False) or self.check_obj_is_related(obj))
+
+        return result

gecoscc/api/organisationalunits.py

@@ -36,17 +36,23 @@ class OrganisationalUnitResource(TreeResourcePaginated):
     def integrity_validation(self, obj, real_obj=None):
         status = super(OrganisationalUnitResource,
                        self).integrity_validation(obj, real_obj)
-        if (real_obj is not None and obj['path'] != real_obj['path']):
-            # Check if the ou is moving to self depth, that is not correct.
-            if obj['path'] in real_obj['path']:
-                self.request.errors.add(
-                    obj[self.key], 'path',
-                    "the ou is moving to self depth position, "
-                    "that is not allowed")
-            return False
-        status = status and self.check_unique_node_name_by_type_at_domain(obj)
+
+        if real_obj is not None and obj['path'] != real_obj['path']:
+            status_user = self.request.user.get('is_superuser', False) or self.is_ou_empty(obj)
+            status = status and status_user
         return status
 
+    def is_ou_empty(self, obj):
+        '''
+        Check if the Ou contains any object
+        '''
+        ou_children = self.collection.find({'path': {'$regex': '.*' + unicode(obj['_id']) + '.*'}}).count()
+
+        if ou_children == 0:
+            return True
+        else:
+            return False
+
     def post_save(self, obj, old_obj=None):
         """ Check if path has changed to refresh children nodes """
         if (self.request.method == 'PUT' and old_obj and

gecoscc/api/printer_models.py

@@ -36,7 +36,7 @@ def get_distinct_filter(self, objects):
         if self.request.GET.get('manufacturers_list'):
             objects = objects.distinct('manufacturer')
             objects.sort()
-            objects = [{'manufacturer':m, 'model':''} for m in objects]
+            objects = [{'manufacturer': m, 'model': ''} for m in objects]
         return objects
 
     def set_name_filter(self, query, key_name='manufacturer'):