Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup rfs client #21

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: setup rfs client #21

wants to merge 1 commit into from

Conversation

Blankll
Copy link
Member

@Blankll Blankll commented Dec 15, 2024

feat|fix|refactor: summary title of the PR

Introduce a request id and a reference to latest request. Dismiss
incoming responses other than from latest request.

Remove timeouts which were used to mitigate the racing issue but are
obsolete now.

Refs: #19

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (d4cf33e) to head (b8f16bf).

Files with missing lines Patch % Lines
src/common/rfsClient.ts 62.50% 9 Missing ⚠️
src/stack/deploy.ts 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   88.67%   86.68%   -2.00%     
==========================================
  Files          40       41       +1     
  Lines         415      443      +28     
  Branches       55       60       +5     
==========================================
+ Hits          368      384      +16     
- Misses         31       42      +11     
- Partials       16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant