-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARISTOTLE: plot shakemap #10112
Merged
Merged
ARISTOTLE: plot shakemap #10112
+328
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g shakemap or finite-fault
…a below the button
…e rupture data' button [ci skip]
… in a different way
… the url in a different way" This reverts commit f724794.
micheles
reviewed
Nov 6, 2024
@@ -59,6 +78,51 @@ def get_country_iso_codes(calc_id, assetcol): | |||
return id_0_str | |||
|
|||
|
|||
def plt_to_base64(plt): | |||
bio = io.BytesIO() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are using base64? Is it required by the javascript side? Please add a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a docstring explaining it
… the rupture and the hypocenter
micheles
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10107
After pressing the "Retrieve rupture data" button, the average gmfs for PGA and MMI are displayed below the button, if the shakemap data is available from the USGS service.
In the same plots, I am also drawing the hypocenter and the boundaries of the rupture. I am keeping the surface of the rupture transparent, in order to avoid hiding/altering the colors of the gmfs.
Keeping the two maps in a single row made them look very small and hard to read, so I decided to plot them bigger and to display them one below the other.