feat: use 'testplane.config.[tj]s' config name #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Sep 30, 2024
Comment on lines
+4
to
+7
| TESTPLANE_NEW_TS: "testplane.config.ts", | ||
| TESTPLANE_NEW_CTS: "testplane.config.cts", | ||
| TESTPLANE_NEW_JS: "testplane.config.js", | ||
| TESTPLANE_NEW_CJS: "testplane.config.cjs", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Тут перечисляем список, чтобы кидать ошибку при попытке перезаписать имеющийся конфиг (проинициализировать testplane в проекте, где он уже есть):
Looks like .../my-project-dir already contains "testplane.config.ts".
Please remove old config or choose another directory.
Looks like .../my-project-dir already contains ".testplane.conf.ts".
Please remove old config or choose another directory.
sipayRT
approved these changes
Sep 30, 2024
| @@ -12,7 +12,14 @@ describe("package", () => { | |||
| }); | |||
|
|
|||
| describe("initApp", () => { | |||
| [".testplane.conf.ts", ".testplane.conf.js", ".hermione.conf.ts", ".hermione.conf.js"].forEach(configName => { | |||
| [ | |||
| ".testplane.conf.ts", | |||
There was a problem hiding this comment.
you can get names from CONFIG_NAMES constant instead of manually synchronizing them here
There was a problem hiding this comment.
It is good in source files, but i dont think it is in test files. I want small typo in CONFIG_NAMES to break these tests, so you would double-check it here
DudaGod
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.