Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize urls while merging reports #503

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: normalize urls while merging reports #503

merged 1 commit into from
Sep 13, 2023

Conversation

KuznetsovRoman
Copy link
Member

Что сделано

Учтен случай, когда *.json возвращает локальную sqlite базу

shadowusr
shadowusr approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Визуально ok, я бы потестил на реальном проекте и в CI

@KuznetsovRoman KuznetsovRoman merged commit 1096261 into master Sep 13, 2023
5 checks passed
@KuznetsovRoman KuznetsovRoman deleted the HERMIONE-1166.normalize_urls branch September 13, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowusr shadowusr shadowusr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuznetsovRoman @shadowusr