fix: add playwright visual checks results to correct steps in new ui #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
approved these changes
Nov 26, 2024
| // Built-in playwright screenshot assertion | ||
| (step.data.title.includes('toHaveScreenshot') && step.data.title.includes(image.stateName ?? '')) || | ||
| // Assertions provided by gemini-testing playwright-utils | ||
| (step.data.title.includes('toMatchScreenshot')) && (step.children?.[0]?.data as Action)?.title?.includes(image.stateName ?? '') |
shadowusr
force-pushed
the
users/shadowusr/INFRADUTY-27961.fix-visual-assertions
branch
from
b33ed87 to
5b50d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in pwt visual assertions were added as "assertView" commands at the end of the test. This PR makes it so that they are added to corresponding toMatchScreenshot commands.
Demo report: https://nda.ya.ru/t/jzvnUjB779sizC