feat: implement tests sorting #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
approved these changes
Dec 5, 2024
lib/static/new-ui/features/suites/components/SuitesTreeView/utils.ts
Outdated
Show resolved
Hide resolved
lib/static/new-ui/features/suites/components/SuitesTreeView/utils.ts
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| return sortAndGetWeight(treeNodes).sortedTreeNodes; | ||
| }; |
There was a problem hiding this comment.
a little bit complicated logic here, but i don't how it makes simpler. Just a lot of cases which should be covered.
There was a problem hiding this comment.
I agree, so I once again looked at the code and tried to simplify it. What's came out of this:
- There is no referring to magic indexes like [0], [1] anymore, I introduced weight metadata instead, which is type-safe and more explicit & readable
- Got rid of duplicating logic related to adding tags, and the code's become a lot cleaner
The file is still pretty large, but more readable and clear.
| const treeNodesCopy = treeNodes.slice(0); | ||
| const weights: Record<string, TreeNodeWeight> = {}; | ||
|
|
||
| treeNodesCopy.forEach((treeNode, index) => { |
There was a problem hiding this comment.
Agree! So I decided to fix it. Replied here: #621 (comment)
shadowusr
force-pushed
the
users/shadowusr/TESTPLANE-349
branch
from
c27ee15 to
117a268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done
Demo report: https://nda.ya.ru/t/r_tGtS0S7A9u5q