Merge pull request #19 from gemini-testing/TESTPLANE-165.newWindow

docs: add warning about newWindow command
gemini-testing · Jul 30, 2024 · f893306 · f893306
2 parents a93f786 + 2349dae
commit f893306
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/docs/commands/browser/newWindow.mdx b/docs/commands/browser/newWindow.mdx
@@ -12,6 +12,24 @@ import Admonition from "@theme/Admonition";
 
 <Admonition type="warning">Команда _newWindow_ не работает в мобильных окружениях (!)</Admonition>
 
+<Admonition type="warning">
+    Команда может не работать c _devtools_ протоколом. Также она не дожидается загрузки страницы.
+    Чтобы решить эти проблемы, рекомендуется перезаписать команду (на стороне Testplane это будет сделано в версии 9.0.0):
+    ```javascript
+    browser.overwriteCommand("newWindow", async function(pageUrl, windowName, windowFeatures) {
+        if (browser.isDevTools) {
+            const puppeteer = await browser.getPuppeteer();
+            await puppeteer.newPage();
+        } else {
+            await browser.newWindow("about:blank", windowName, windowFeatures);
+        }
+
+        await browser.url(pageUrl);
+    });
+    ```
+
+</Admonition>
+
 ## Использование {#usage}
 
 ```javascript

diff --git a/i18n/en/docusaurus-plugin-content-docs/current/commands/browser/newWindow.mdx b/i18n/en/docusaurus-plugin-content-docs/current/commands/browser/newWindow.mdx
@@ -14,6 +14,24 @@ Note that this command will automatically switch you to the new window upon exec
     The _newWindow_ command does not work in mobile environments (!)
 </Admonition>
 
+<Admonition type="warning">
+    The command might not work with _devtools_ protocol. It also does not wait untill page load.
+    In order to fix these problems, it is recommended to overwrite the command (on the Testplane side it would be done in version 9.0.0):
+    ```javascript
+    browser.overwriteCommand("newWindow", async function(pageUrl, windowName, windowFeatures) {
+        if (browser.isDevTools) {
+            const puppeteer = await browser.getPuppeteer();
+            await puppeteer.newPage();
+        } else {
+            await browser.newWindow("about:blank", windowName, windowFeatures);
+        }
+
+        await browser.url(pageUrl);
+    });
+    ```
+
+</Admonition>
+
 ## Usage {#usage}
 
 ```javascript