Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to specify autoscreenshotSelector globally #30

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

KuznetsovRoman
Copy link
Member

No description provided.

@KuznetsovRoman KuznetsovRoman force-pushed the TESTPLANE-357.autoscreenshotSelector branch from 801eec1 to 3c14fe9 Compare December 2, 2024 02:35
Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to write one more test with check global autoscreenshotSelector (If I understood everything correctly)

stories: [storySecond],
opts,
});

expect(storyTestFiles).toEqual([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where the test in which you check that autoscreenshotSelector from story has more priority then autoscreenshotSelector from config?

Copy link
Member Author

@KuznetsovRoman KuznetsovRoman Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can not be tested with unit tests, as this code is inside story-test-runner, so the file just generates testplane tests (so its just a file with auto-executed function, which generates its and describes)

@KuznetsovRoman KuznetsovRoman merged commit a84c2ad into master Dec 5, 2024
2 checks passed
@KuznetsovRoman KuznetsovRoman deleted the TESTPLANE-357.autoscreenshotSelector branch December 5, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants