Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General DM class #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

douglase
Copy link

@mperrin this has been sitting in my branch for over a year but has come in handy so I though'd put in a PR.

Thoughts? I think @neilzim may have done something similar?

@mperrin
Copy link
Collaborator

mperrin commented Mar 14, 2018

Oh nice. @neilzim may indeed be interested, as we're working right now on some proposals related to end to end modeling of the LUVOIR instrument and our HiCAT testbed. I've not kept up to date on how much of that is being done with PROPER vs. POPPY.

Ideally we should merge some/all of the general DM framework upstream into POPPY for more visibility, I think.

@neilzim
Copy link

neilzim commented Mar 14, 2018

Thanks, this would indeed be very useful. I did write my own poppy DM class based on the one in gpipsf, it might have some features worth merging with @douglase

@mperrin
Copy link
Collaborator

mperrin commented Mar 27, 2018

@neilzim is your general DM class available? I'm interested in merging that (or this, or a combination thereof) into poppy.

As I now have some additional free time over the next few weeks (ha?), I'm thinking I'd like to get started on building the poppy model of the HiCAT testbed. I want to work with Laurent on that to get a version of Johan's ACAD-OSM running in Python too.

@neilzim
Copy link

neilzim commented Mar 28, 2018

I just uploaded my version of the poppy DM class (dms.py) along with an example notebook: https://github.com/neilzim/poppy_singleDM_coronagraph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants