feat: mayan integration #322
Conversation
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct PermitParams { |
There was a problem hiding this comment.
maybe we can reuse gem_evm::erc2612.rs, change r/s to [u8; 32]
There was a problem hiding this comment.
tbh I don't think we will use permit at all
I keep this structure just to keep the interface similar to what contract expects
| use primitives::Chain; | ||
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq, Hash)] | ||
| pub enum MayanSwiftDeploymentWormholeId { |
There was a problem hiding this comment.
nitpick, this is really long, let's just call it WormholdChainId?
| Some(evm_address.to_string()) | ||
| ); | ||
| assert_eq!(get_swift_deployment_by_chain(Chain::Polygon).map(|x| x.address), Some(evm_address.to_string())); | ||
| // assert_eq!(get_swift_deployment_by_chain(Chain::Avalanche).map(|x| x.address), Some(evm_address.to_string())); |
There was a problem hiding this comment.
| // assert_eq!(get_swift_deployment_by_chain(Chain::Avalanche).map(|x| x.address), Some(evm_address.to_string())); |
| })?, | ||
| amountIn: amount_in, | ||
| permitParams: permit.map_or(MayanSwiftPermit::zero().to_contract_params(), |p| p.to_contract_params()), | ||
| swapProtocol: Address::from_str(swap_protocol).map_err(|e| MayanForwarderError::ABIError { |
There was a problem hiding this comment.
if you add a From<AddressError> for MayanForwarderError, it would be easier to return an address error just passing .map_err(MayanForwarderError::from
|
|
||
| #[derive(Debug, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
I guess this can be removed now? all the allow(dead_code) in this file
| params.from_chain.to_string() | ||
| }; | ||
|
|
||
| let mut query_params = vec
There was a problem hiding this comment.
Yes, that's a good idea, I know it's used in other places too, like Thorchain. So pass Asset instead of AssetId in swap quote request?
|
|
||
| async fn fetch_quote(&self, request: &SwapQuoteRequest, provider: Arc<dyn AlienProvider>) -> Result<SwapQuote, SwapperError> { | ||
| // Validate chain support | ||
| if !self.supported_chains().contains(&request.from_asset.chain) { |
There was a problem hiding this comment.
should we also check from chain != to chain?
| } | ||
|
|
||
| async fn get_transaction_status(&self, chain: Chain, transaction_hash: &str, provider: Arc<dyn AlienProvider>) -> Result<bool, SwapperError> { | ||
| todo!(); |
There was a problem hiding this comment.
is there any endpoint to query this tx status? we can add it later for this method
No description provided.