Deprecate inherit_collection parmeter in duplicate() methods

genialis · Nov 8, 2023 · e71a342 · e71a342
1 parent 28e17f7
commit e71a342
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/docs/CHANGELOG.rst b/docs/CHANGELOG.rst
@@ -5,6 +5,16 @@ Change Log
 All notable changes to this project are documented in this file.
 
 
+==========
+Unreleased
+==========
+
+Changed
+-------
+- **BACKWARD INCOMPATIBLE:** Remove ``inherit_collection`` parameter in
+  ``Data.duplicate()`` and ``Sample.duplicate()``
+
+
 ===================
 20.0.0 - 2023-10-27
 ===================

diff --git a/src/resdk/resources/data.py b/src/resdk/resources/data.py
@@ -354,16 +354,11 @@ def stdout(self):
         return output.decode("utf-8")
 
     @assert_object_exists
-    def duplicate(self, inherit_collection=False):
+    def duplicate(self):
         """Duplicate (make copy of) ``data`` object.
 
-        :param inherit_collection: If ``True`` then duplicated data
-            will be added to collection of the original data.
-
         :return: Duplicated data object
         """
-        task_data = self.api().duplicate.post(
-            {"ids": [self.id], "inherit_collection": inherit_collection}
-        )
+        task_data = self.api().duplicate.post({"ids": [self.id]})
         background_task = BackgroundTask(resolwe=self.resolwe, **task_data)
         return self.resolwe.data.get(id__in=background_task.result())
diff --git a/src/resdk/resources/sample.py b/src/resdk/resources/sample.py
@@ -237,17 +237,12 @@ def is_background(self):
         return self._is_background
 
     @assert_object_exists
-    def duplicate(self, inherit_collection=False):
+    def duplicate(self):
         """Duplicate (make copy of) ``sample`` object.
 
-        :param inherit_collection: If ``True`` then duplicated samples
-            (and their data) will be added to collection of the original
-            sample.
         :return: Duplicated sample
         """
-        task_data = self.api().duplicate.post(
-            {"ids": [self.id], "inherit_collection": inherit_collection}
-        )
+        task_data = self.api().duplicate.post({"ids": [self.id]})
         background_task = BackgroundTask(resolwe=self.resolwe, **task_data)
         return self.resolwe.sample.get(id__in=background_task.result())