Replace int64 with nullable Int64 in RNATables #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JureZmrzlikar would you please review this. |
JureZmrzlikar
approved these changes
Apr 8, 2024
AnzeLovse
force-pushed
the
fix/rnatables-ints
branch
from
e139f90 to
6398e17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling RNATables.qc would fail with
Cannot convert non-finite values (NA or inf) to integer: Error while type casting for column 'star_assigned_reads'in cases where MultiQC data is not available for a subset of samples.All other integer columns use
Int64dtype which supports missing values (https://pandas.pydata.org/docs/user_guide/integer_na.html).