v1.4.0-beta.8

- fixed occasional "collection was modified" error when building the modules list - testing update system after fix introduced in beta.7
genielabs · Jan 7, 2023 · 31d82ec · 31d82ec
1 parent ec02143
commit 31d82ec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/HomeGenie/Data/Module.cs b/src/HomeGenie/Data/Module.cs
@@ -90,6 +90,11 @@ public Module()
             Stores = new TsList<Store>();
         }
 
+        public Module Clone()
+        {
+            return (Module)MemberwiseClone();
+        }
+
     }
 }
 
diff --git a/src/HomeGenie/Service/Utility.cs b/src/HomeGenie/Service/Utility.cs
@@ -60,7 +60,7 @@ public static class SerializationExtensions
         public static T DeepClone<T>(this T source)
         {
             // Don't serialize a null object, simply return the default for that object
-            if (Object.ReferenceEquals(source, null))
+            if (ReferenceEquals(source, null))
             {
                 return default(T);
             }
@@ -250,7 +250,7 @@ public static string Module2Json(Module module, bool hideProperties)
                 var resolver = new IgnorePropertyContractResolver(new List<string>{ "Properties" });
                 settings.ContractResolver = resolver;
             }
-            return JsonConvert.SerializeObject(module, settings);
+            return JsonConvert.SerializeObject(module.Clone(), settings);
         }
 
         public static string JsonEncode(string fieldValue)