Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JASEN to support PRP v0.10.0 #338

Merged
merged 18 commits into from
Aug 29, 2024

Conversation

mhkc
Copy link
Collaborator

@mhkc mhkc commented Aug 14, 2024

Description

##Remove elements in cursive as needed.##

If not self-evident, mention what prompted the change.

Summary of the changes made:

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

Either describe a procedure, or add data; that confirms that the PR resolves what it sets out to do

Sign-offs

@ryanjameskennedy
Copy link
Collaborator

Should we run this for adding the bam and symlinkDir? We already add these using prp create-bonsai-input. I think we should either move these to prp add-igv-annotation-track or vice versa. I also think this is not very explicit despite these files being explicitly for a purpose.

@ryanjameskennedy ryanjameskennedy marked this pull request as ready for review August 28, 2024 16:36
@ryanjameskennedy ryanjameskennedy requested a review from a team as a code owner August 28, 2024 16:36
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanjameskennedy ryanjameskennedy merged commit f4b02b7 into master Aug 29, 2024
3 checks passed
@ryanjameskennedy ryanjameskennedy deleted the update-prp-to-version-010 branch August 29, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants