Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sccmec module #384

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Conversation

Emkago
Copy link
Contributor

@Emkago Emkago commented Jan 21, 2025

Description

I have added a tool for typing SCCmec cassettes in assemblies of Staphylococcus species.

Summary of the changes made:

  • added a new module
  • included the module in S. aureus workflow
  • edited config files

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

I have tested it with Nanopore test data.

Sign-offs

@Emkago Emkago requested a review from a team as a code owner January 21, 2025 12:10
@Emkago Emkago linked an issue Jan 21, 2025 that may be closed by this pull request
@Emkago
Copy link
Contributor Author

Emkago commented Jan 21, 2025

Analysis is currently not limited to short- or long-read track, but it can be changed later if desired. Results of the analysis are available in the output folder, but are not (yet) reported in the final json file.

Emkago and others added 2 commits January 21, 2025 14:42
Co-authored-by: Ryan James Kennedy <[email protected]>
Co-authored-by: Ryan James Kennedy <[email protected]>
@ryanjameskennedy
Copy link
Collaborator

Analysis is currently not limited to short- or long-read track, but it can be changed later if desired. Results of the analysis are available in the output folder, but are not (yet) reported in the final json file.

Yeah you would have to add the parsing of the output file to bonsai-prp. I have already made an issue.

@Emkago
Copy link
Contributor Author

Emkago commented Jan 22, 2025

I see you have changed reporting of the version of the tool. Have you seen that it reports verisons of 3 components? Output looks like this:

sccmec --version
camlhmp, version 1.1.0
schema sccmec_targets, version 1.2.0
schema sccmec_regions, version 1.2.0

@ryanjameskennedy
Copy link
Collaborator

ryanjameskennedy commented Jan 22, 2025

I see you have changed reporting of the version of the tool. Have you seen that it reports verisons of 3 components? Output looks like this:

sccmec --version
camlhmp, version 1.1.0
schema sccmec_targets, version 1.2.0
schema sccmec_regions, version 1.2.0

Indeed, all we want is the version number (X.X.X format, excl. software name, etc.) that matches the tool version number (which will either be targets/regions).

Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! When you have added a parsing function to bonsai-prp, then you can create another PR to JASEN to include it in output:)

@Emkago Emkago merged commit 23d3560 into master Jan 22, 2025
3 checks passed
@ryanjameskennedy ryanjameskennedy deleted the 374-add-sccmec-analysis-to-mrsa-nanopore-track branch January 22, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SCCmec analysis to MRSA Nanopore track
2 participants