-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sccmec module #384
Add sccmec module #384
Conversation
Analysis is currently not limited to short- or long-read track, but it can be changed later if desired. Results of the analysis are available in the output folder, but are not (yet) reported in the final json file. |
Co-authored-by: Ryan James Kennedy <[email protected]>
Co-authored-by: Ryan James Kennedy <[email protected]>
Yeah you would have to add the parsing of the output file to bonsai-prp. I have already made an issue. |
I see you have changed reporting of the version of the tool. Have you seen that it reports verisons of 3 components? Output looks like this:
|
Indeed, all we want is the version number ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! When you have added a parsing function to bonsai-prp, then you can create another PR to JASEN to include it in output:)
Description
I have added a tool for typing SCCmec cassettes in assemblies of Staphylococcus species.
Summary of the changes made:
Primary function of PR
Testing
I have tested it with Nanopore test data.
Sign-offs