Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/snakemake and deps: version bumps #1296

Closed
wants to merge 5 commits into from

Conversation

mschubert
Copy link
Contributor

@mschubert mschubert commented Nov 11, 2024

Removal of BDEPENDS in snakemake-8.25.3.ebuild is tested and those deps are not required

Ignored/deselected tests have been reported upstream: snakemake/snakemake#2961 or are missing additional plugin ebuilds

Comment on lines +64 to +65
# ImportError: cannot import name 'snakemake' from 'snakemake.script'
tests/test_script_py/scripts/test_explicit_import.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does setting PYTHONPATH (or similar) help for this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this comment correctly, it is not a matter of simply adding to PYTHONPATH:

running from snakemake.script import snakemake outside of a Snakemake "context", since snakemake.script.snakemake (lower case) is simply a type hint that can be used by editor. At execution time, the snakemake object needs to be created by snakemake, which is done by the boilerplate/preamble

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment seems to suggest that passing some path to epytest would resolve the problem, have you tried this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import works neither in ${BUILD_DIR}/build/lib nor ${BUILD_DIR}/install/${EPREFIX}/<python-site-dir>, nor with these added to $PYTHONPATH in the original directory.

Given that this PR is already an improvement over restricting all tests, I'd suggest to accept excluding this test until I can dig more into it.

@gentoo-bot gentoo-bot closed this in fd72ee2 Feb 6, 2025
@Nowa-Ammerlaan
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants