Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-878: Filter out KML outside print extent #1055

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

PB-878: Filter out KML outside print extent #1055

wants to merge 25 commits into from

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Sep 2, 2024 •
edited by github-actions bot
Loading

Test link

Tested with this file:

super-big.zip

Test link

@cypress Cypress
Copy link

cypress bot commented Sep 2, 2024 •
edited
Loading

web-mapviewer    Run #4233

Run Properties:  status check failed Failed #4233  •  git commit 6d54a1ca27: PB-878: Address PR review.
Project web-mapviewer
Branch Review pb-878-filter-out-kml
Run status status check failed Failed #4233
Run duration 06m 28s
Commit git commit 6d54a1ca27: PB-878: Address PR review.
Committer Ismail Sunni
View all properties for this run ↗︎
Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 175
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/tests-e2e/print.cy.js • 4 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (with KML layer) - with import layer Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint with GPX layer Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (icon and label) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (KML from old geoadmin) Test Replay Screenshots

@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch from 3f4f219 to 76e6dff Compare September 4, 2024 08:36
@ismailsunni ismailsunni marked this pull request as ready for review September 4, 2024 09:04
@ismailsunni ismailsunni requested review from ltshb and pakb and removed request for ltshb September 4, 2024 09:04
@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch from 60fa6e4 to 4040237 Compare September 4, 2024 09:21
@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch 3 times, most recently from 86980db to 48d6f92 Compare September 5, 2024 06:45
@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch 5 times, most recently from 77d1691 to 70eb9d9 Compare October 7, 2024 06:56
@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch from 2f20e4a to 89b0be4 Compare November 25, 2024 03:19
@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch from 89b0be4 to 0947b5f Compare December 11, 2024 13:17
pakb
pakb reviewed Dec 11, 2024
View reviewed changes
tests/cypress/tests-e2e/print.cy.js Outdated Show resolved Hide resolved
src/api/print.api.js Outdated Show resolved Hide resolved
tests/cypress/tests-e2e/print.cy.js Outdated Show resolved Hide resolved
tests/cypress/tests-e2e/print.cy.js Outdated Show resolved Hide resolved
tests/cypress/tests-e2e/print.cy.js Outdated Show resolved Hide resolved
@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch 3 times, most recently from 3162009 to dd0a3c3 Compare January 6, 2025 11:09
@ismailsunni
PB-878: Check center and zoom level for failed test.
014a4ab
@ismailsunni
PB-878: Also test the zoom level
26fb7f3
@ismailsunni
PB-878: Add check for layers loaded in OpenLayers.
400f9ca
@ismailsunni
PB-878: Add wait (test only, removed later).
0aadec0
@ismailsunni
PB-878: Add render check on checkOlLayer.
2d81cdf
@ismailsunni
PB-878: Check if there are features and the extent is correct.
56b73cd
@ismailsunni
PB-878: remove check on rendering.
3194bae
@ismailsunni
PB-878: Log the layer type.
06af32d
@ismailsunni
PB-878: More cy.log to see the failed layer.
97f9e5f
@ismailsunni
PB-878: Try with import file to load KML.
c643af3
@ismailsunni
PB-878: Skip duplicated test.
a79c4cf
@ismailsunni
PB-878: Fix import issue on runt unit test.
f5c6a32
@ismailsunni
PB-878: Tidy up code.
8d49811
@ismailsunni
PB-878: Re-enable test with import layer.
9b74dfd
@ismailsunni
PB-878: Remove unused comment.
773735e
@ismailsunni
PB-878: Use readFile to prevent failure of reading fixture file.
4cf2b63
@ismailsunni
PB-878: Address PR review.
6d54a1c
@ismailsunni ismailsunni force-pushed the pb-878-filter-out-kml branch from dd0a3c3 to 6d54a1c Compare January 9, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailsunni @pakb