Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Release v1.49.3 - #patch #1154

Merged
merged 2 commits into from
Dec 2, 2024
Merged

New Release v1.49.3 - #patch #1154

merged 2 commits into from
Dec 2, 2024

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Dec 2, 2024 •
edited by github-actions bot
Loading

ltkum and others added 2 commits December 2, 2024 14:30
@ltkum
PB-1260: handle legacy value 'voidLayer'
b04e016 
Issue: In the old mapviewer, it was possible to have the bgLayer parameter to equals 'voidLayer', which is equivalent to the current 'void' parameter. However, it caused issues where it displayed errors and refused to show the correct "layer".

Cause: we did not handle the parameter at all in the legacy parser.

Fix: when bgLayer is set to 'voidLayer' while navigating a legacy route, we handle it correctly and transform it to 'void'
@pakb
Merge pull request #1153 from geoadmin/fix-PB-1260-voidLayer-full-sup…
4dec99d 
…port

PB-1260: handle legacy value 'voidLayer'
@pakb pakb requested a review from ltkum December 2, 2024 13:48
@github-actions github-actions bot changed the title legacy void layer fix #patch New Release v1.49.3 - #patch Dec 2, 2024
ltkum
ltkum approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ho look, it's changes you approved less than 5 minutes ago

I'll approve them too

@cypress Cypress
Copy link

cypress bot commented Dec 2, 2024

web-mapviewer    Run #3954

Run Properties:  status check passed Passed #3954  •  git commit 4dec99d875: Merge pull request #1153 from geoadmin/fix-PB-1260-voidLayer-full-support
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #3954
Run duration 01m 43s
Commit git commit 4dec99d875: Merge pull request #1153 from geoadmin/fix-PB-1260-voidLayer-full-support
Committer Pascal Barth
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@pakb pakb merged commit 0123ff8 into master Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltkum ltkum ltkum approved these changes

Assignees
No one assigned
Labels
new-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pakb @ltkum