Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release v1.51.0 - #minor #1204

Closed
wants to merge 112 commits into from
Closed

New Release v1.51.0 - #minor #1204

wants to merge 112 commits into from

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Jan 16, 2025

pakb and others added 30 commits December 17, 2024 12:36
block typescript update to v5.6.3, going further is not compatible with vue-tsc at the moment (see vuejs/language-tools#4484 )

issue with flickering label in Cesium has been fixed with latest release, we can go back to using the latest version in our dependecies
…file

PB-1216: Add warning on sharing when there is a local files.
Issue: The compass in the 3d viewer was hidden

Cause: We checked before there was an instance of the component if we could add the scene and the clock to the compass element, meaning it would create an empty compass.

Fix: We wait for the map to be ready before adding the compass
ismailsunni and others added 20 commits January 14, 2025 11:29
…-is-hidden

PB-400: Add test for hiding the dropdown adter selecting a search result
…rnally.

This involves translating the title in the getter, such that when called, it is
up-to-date with the current language context in web-mapviewer.
instead of failing and raising an error while using t(...), vue-i18n now gives back the "key" or text it received unchanged. This way we can call translation tool on input from other component without worrying on raising errors.

The DropdownButton now translates anything it receives, making it possible to give it either keys, or translated text directly.

Removing the class DropdownItem and replacing it with a typedef instead. We now know that passing classes with get/set to Vuex is a bad practice, and we should avoid it.
Adapted the cypress tests to the new drop down item values.
so that it uses aliases on element whenever possible, and also test the payload of feedback for the category too.
…tion-issue

PB-1327: Refactored 'DropdownItem' to translate the button title internally
to fix the issue with label flickering.

Also updating all other libs in the process.
I had to delete and recreate the package-lock.json for things to work properly (related to migration to Node22 maybe?)
Issue: We want the users to understand what each category is used for in the feedback form.

Fix: We add a link under the category selection that leads to the news about the categories. In the near future, we'll change the link to the help page itself.
@github-actions github-actions bot changed the title new release New Release v1.51.0 - #minor Jan 16, 2025
@ltshb ltshb changed the title New Release v1.51.0 - #minor New Jan 16, 2025
@github-actions github-actions bot changed the title New New Release v1.51.0 - #minor Jan 16, 2025
@ltshb ltshb changed the title New Release v1.51.0 - #minor New Jan 16, 2025
@github-actions github-actions bot changed the title New New Release v1.51.0 - #minor Jan 16, 2025
ltshb and others added 3 commits January 16, 2025 20:14
there are from time to time console.log (or console.error) that slips through our review process.
To counter that I've activated the ESLint no-console rule on all non-test, non-script files.
@pakb pakb closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants