-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release v1.51.0 - #minor #1204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
block typescript update to v5.6.3, going further is not compatible with vue-tsc at the moment (see vuejs/language-tools#4484 ) issue with flickering label in Cesium has been fixed with latest release, we can go back to using the latest version in our dependecies
PB-1301 : migration to Node22 and update libs
…ormation-feature-info PB-1223: add test more information feature info
Issue: The compass in the 3d viewer was hidden Cause: We checked before there was an instance of the component if we could add the scene and the clock to the compass element, meaning it would create an empty compass. Fix: We wait for the map to be ready before adding the compass
PB-1310: 3D navigation compass was not showing
…aram-function-tests PB-1263: add handleLegacyParam function tests
…-is-hidden PB-400: Add test for hiding the dropdown adter selecting a search result
…text-labels-configurable PB-1297: make position of text labels configurable
…g-drawing-mode PB-580: Add warning when drawing could get lost otherwise
…rnally. This involves translating the title in the getter, such that when called, it is up-to-date with the current language context in web-mapviewer.
instead of failing and raising an error while using t(...), vue-i18n now gives back the "key" or text it received unchanged. This way we can call translation tool on input from other component without worrying on raising errors. The DropdownButton now translates anything it receives, making it possible to give it either keys, or translated text directly. Removing the class DropdownItem and replacing it with a typedef instead. We now know that passing classes with get/set to Vuex is a bad practice, and we should avoid it.
Adapted the cypress tests to the new drop down item values.
so that it uses aliases on element whenever possible, and also test the payload of feedback for the category too.
…tion-issue PB-1327: Refactored 'DropdownItem' to translate the button title internally
to fix the issue with label flickering. Also updating all other libs in the process. I had to delete and recreate the package-lock.json for things to work properly (related to migration to Node22 maybe?)
PB-1348 : revert Cesium to 1.119.0
Issue: We want the users to understand what each category is used for in the feedback form. Fix: We add a link under the category selection that leads to the news about the categories. In the near future, we'll change the link to the help page itself.
…k-for-categories PB-1343: add "more info" link in problem report form
Update build badges
Update master
there are from time to time console.log (or console.error) that slips through our review process. To counter that I've activated the ESLint no-console rule on all non-test, non-script files.
Enforce ESLint no-console rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link