Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release v1.51.1 - #patch #1212

Merged
merged 9 commits into from
Jan 20, 2025
Merged

New Release v1.51.1 - #patch #1212

merged 9 commits into from
Jan 20, 2025

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Jan 20, 2025

sommerfe and others added 4 commits January 20, 2025 10:43
using window.open to trigger a download (of the print results) was triggering the beforeUnload event in MapView.vue's code, and showing the "you'll lose your drawing" warning, while we stay on the page in the end.

Also fixing some usage of the old $t to the new Composition API equivalent
…rint

PB-1355 : don't show drawing lost warning when we open download PDFs
@github-actions github-actions bot changed the title #patch New Release v1.51.1 - #patch Jan 20, 2025
ltkum and others added 3 commits January 20, 2025 16:48
Issue : when trying to print imported kmls, we sometimes ran into an issue where there was no offset, and the printing service was not able to interpret a field not being present

Fix : We now add a little line to ensure offsets exists in line when printing
PB 1358: fix issue with printing imported KMLS
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ho wait, I already reviewed that :)

looks good to me

@pakb pakb merged commit f20620d into master Jan 20, 2025
8 checks passed
Copy link

cypress bot commented Jan 20, 2025

web-mapviewer    Run #4344

Run Properties:  status check passed Passed #4344  •  git commit f20620d2ee: Merge pull request #1212 from geoadmin/develop
Project web-mapviewer
Branch Review master
Run status status check passed Passed #4344
Run duration 01m 44s
Commit git commit f20620d2ee: Merge pull request #1212 from geoadmin/develop
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants