PB-1031: redirect github link to release page #1216
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1031-add-github-link-to-release
|
| Run status |
|
| Run duration | 04m 25s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
232
|
| View all changes introduced in this branch ↗︎ | |
ltkum
force-pushed
the
feat-PB-1031-add-github-link-to-release
branch
from
972f675 to
d6d0fcf
Compare
pakb
reviewed
Jan 21, 2025
There was a problem hiding this comment.
I'd separate the AppVersion button into two buttons, one with only the GitHub icon (and that redirect to https://github.com/geoadmin/web-mapviewer) and the other one containing the version (and redirect to the version if and only if the version is stable (not containing dirty or beta keyword)
Github link now leads to the release notes
ltkum
force-pushed
the
feat-PB-1031-add-github-link-to-release
branch
from
d966bbc to
bbf7931
Compare
- The github icon link redirects to the repository - The app version link redirects to the release IF this is a clean version, otherwise it leads to the repository
ltkum
force-pushed
the
feat-PB-1031-add-github-link-to-release
branch
from
bbf7931 to
7208133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github link now leads to the specific release
Test link