Implement conversions from GEOS objects to GeoArrow arrays #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
ConstGeometry<'a, 'b>with two lifetimes now. It seemed super difficult to get that to mesh with the geometry access traits, so I just reimplemented manual conversionsbumpalobut didn't see any speed difference. So maybe GEOS is still allocating geometries on the heap before I get access to them in rust? Not sureCloses #110
It would be interesting if the benchmark improves without cloning the CoordSeq of every polygon: georust/geos#137