Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed fontfaceobserver dependency #16

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ricardogsilva
Copy link

@ricardogsilva ricardogsilva commented Dec 11, 2024

This PR removes the fontfaceobserver third party dependency as it wasn't really being used for anything.

The code was using it for trying to load some font named 'Inter' - however, there was no mention of where this font would be downloaded from annywhere in the code. This meant fontfaceobserver was being pulled as a dependency but not really being used.

It was being used in the code but it not have any effect
@ricardogsilva ricardogsilva marked this pull request as ready for review December 11, 2024 17:52
@ricardogsilva ricardogsilva requested a review from sirmmo December 11, 2024 17:52
@francbartoli francbartoli self-requested a review December 13, 2024 00:08
@francbartoli francbartoli merged commit 29a9ac2 into geobeyond:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants