Add better error handling when providing data downloads from THREDDS #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a workaround for the fact that the upstream THREDDS NCSS service returns an error when a request for a NetCDF file that represents 30-year aggregated data includes a temporal range.
The proposed implementation discards the
datetimequery parameter when the coverage being requested hasaggregation_period:30yras one of its configuration parameters.In addition to this change, this PR also adds better error handling to the API path operation that performs forecast coverage data download. Previously, any errors in the upstream THREDDS NCSS response were ignored. The proposed implementation forwards the response from THREDDS to the client, thus exposing any problems which may occur.