Model upload and positioning #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladyslav-tk
force-pushed
the
model_upload_and_positioning
branch
7 times, most recently
from
7bcff63 to
2f0c84a
Compare
gberaudo
reviewed
Nov 22, 2024
| dataSourceCollection: dataSourceCollection, | ||
| }); | ||
| const clock = viewer.clock; | ||
| // todo: check if OK |
There was a problem hiding this comment.
Do you think of a potential issue with this code?
|
|
||
| render(): HTMLTemplateResult { | ||
| return html` <ngv-upload | ||
| .options="${{accept: '.glb,.GLB'}}" |
There was a problem hiding this comment.
You don't accept .gltf?
Also, no .ifc?
gberaudo
force-pushed
the
model_upload_and_positioning
branch
from
2f0c84a to
ccdc6ec
Compare
gberaudo
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.