(wip?) node ids ios port #46
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rooot <[email protected]>
Signed-off-by: rooot <[email protected]>
|
note that current node ids code doesnt respect safe zones on iphone x and up, have fun with that :3 |
|
I only have an iPad7,11 to test on, so I can't really test or work on that - someone else is probably gonna have to do that |
Signed-off-by: rooot <[email protected]>
v1.10.2
matcool
reviewed
Jun 28, 2024
| @@ -31,7 +31,7 @@ using namespace geode::node_ids; | |||
| "music-offset-input" | |||
| ); | |||
|
|
|||
| #ifdef GEODE_IS_ANDROID | |||
| #if defined(GEODE_IS_ANDROID) || defined(GEODE_IS_IOS) | |||
There was a problem hiding this comment.
maybe use GEODE_IS_MOBILE instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports node ids to ios. (all required bindings are found, although some members are pending in a separate bindings PR)
only things missing are:
this did not crash so far, which is probably a good sign
some IDs have also been confirmed to be correct (CharacterColorPage works fine - see my mod; I personally didn't test the rest)
I'd appreciate if anyone could verify the IDs of other classes, although I'm fairly positive that most (if not all) of them are correct.