Extend indent script to fix changelog entries #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Nov 19, 2024
contrib/utilities/indent
Outdated
| @@ -140,8 +140,10 @@ find tests include source benchmarks cookbooks unit_tests \ | |||
| | xargs -P 10 -I {} bash -c "indent_file {}" | |||
|
|
|||
|
|
|||
| SOURCE_FILES=`find include source unit_tests cookbooks benchmarks doc \( -name '*.cc' -o -name '*.h' -o -name '*.prm' -o -name '*.h.in' -o -name 'CMakeLists.txt' -o -name '*.cmake' -o -name '*.md' -o -wholename '*modules/changes/*' \) -print` | |||
There was a problem hiding this comment.
Sadly, this doesn't work with -print0 in bash, which would be cleaner and safer (special characters in filenames).
gassmoeller
force-pushed
the
extend_indent_to_changes
branch
from
7d52209 to
d90acb0
Compare
|
What about putting it into a function like this version? That seems to work for me. |
gassmoeller
force-pushed
the
extend_indent_to_changes
branch
from
d90acb0 to
82ffad0
Compare
|
@tjhei I think this is ready for another look. The script even found something in the last remaining changelog entry ;-). |
|
/rebuild |
gassmoeller
force-pushed
the
extend_indent_to_changes
branch
from
86f530b to
f2be02c
Compare
|
@tjhei: I think this is ready, can you take a look? |
tjhei
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be rebased and merged after #6152 has been merged. During that other PR I noticed that our changelog entries are not checked and fixed by the indent script. This PR changes the script to include more files when checking for:
I also included the changes this PR would make to the changelog entries (but they will be changed by #6152 anyway).