Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levelset + Barrier Method #88

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

Levelset + Barrier Method #88

wants to merge 31 commits into from

Conversation

LDTalbot
Copy link
Collaborator

@LDTalbot LDTalbot commented Feb 2, 2024

Description
Levelset + Barrier method implementation with frictional barrier method via Zhao et al. (2023).

TODO

  • 2D benchmark tests for sliding block on plane.
  • 3D benchmark tests for sliding block on plane.
  • Benchmark tests for rolling/sliding cylinder/sphere on plane.
  • Adhesion functionality + "uphill" prevention.
  • Damping functionality.
  • Compatible with B-Bar.
  • Resume functionality
  • Computational speed improvements.
  • Add functionality for separate levelset mesh.
  • Write tests.
  • Add documentation: update wiki, example input files, benchmarks.

Potential Issues/Modifications

  • OpenMP
  • MPI
  • Potential levelset normal source of error once mesh is separate
  • RBD levelset

Related Issues

  • Contact functionality
  • Nomenclature for subclasses/derived classes: want e.g. MeshLevelset, ParticleLevelset

@LDTalbot LDTalbot added the enhancement New feature or request label Feb 2, 2024
@LDTalbot LDTalbot self-assigned this Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 9.13242% with 398 lines in your changes missing coverage. Please review.

Project coverage is 94.96%. Comparing base (a0dad92) to head (fde060a).

Files with missing lines Patch % Lines
.../particles/anti_locking/particle_levelset_bbar.tcc 0.00% 133 Missing ⚠️
include/particles/particle_levelset.tcc 0.00% 77 Missing ⚠️
include/mesh/mesh_levelset.tcc 0.00% 56 Missing ⚠️
include/solvers/mpm_base.tcc 29.63% 38 Missing ⚠️
include/io/io_mesh_ascii.tcc 8.00% 23 Missing ⚠️
include/nodes/node_levelset.tcc 0.00% 15 Missing ⚠️
include/nodes/node_base.h 0.00% 12 Missing ⚠️
include/nodes/node_levelset.h 0.00% 12 Missing ⚠️
include/contacts/contact_levelset.tcc 0.00% 11 Missing ⚠️
include/mesh/mesh_levelset.h 0.00% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   90.46%   94.96%   +4.49%     
==========================================
  Files         214      250      +36     
  Lines       47390    51000    +3610     
==========================================
+ Hits        42870    48428    +5558     
+ Misses       4520     2572    -1948     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDTalbot LDTalbot changed the title Levelset Levelset + Barrier Method Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant