Use the copyBlob to copy the resource with updated metadata (#8530)

Prior it was trying to copy the payload which was buggy on large files and could produce the following error "Failed copy of resources: Incomplete output stream connecting to PUT"
geonetwork · Dec 4, 2024 · c5b3fa6 · c5b3fa6
1 parent 5e6f08f
commit c5b3fa6
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/datastorages/jcloud/src/main/java/org/fao/geonet/api/records/attachments/JCloudStore.java b/datastorages/jcloud/src/main/java/org/fao/geonet/api/records/attachments/JCloudStore.java
@@ -610,10 +610,10 @@ public void copyResources(ServiceContext context, String sourceUuid, String targ
                         String sourceBlobName = sourceStorageMetadata.getName();
                         String targetBlobName = targetResourceTypeDir + sourceBlobName.substring(sourceResourceTypeDir.length());
 
-                        Blob sourceBlob = jCloudConfiguration.getClient().getBlobStore().getBlob(jCloudConfiguration.getContainerName(), sourceBlobName);
+                        BlobMetadata blobMetadata = jCloudConfiguration.getClient().getBlobStore().blobMetadata(jCloudConfiguration.getContainerName(), sourceBlobName);
 
                         // Copy existing properties.
-                        Map<String, String> targetProperties = new HashMap<>(sourceBlob.getMetadata().getUserMetadata());
+                        Map<String, String> targetProperties = new HashMap<>(blobMetadata.getUserMetadata());
 
                         // Check if target exists.
                         StorageMetadata targetStorageMetadata = null;
@@ -670,14 +670,14 @@ public void copyResources(ServiceContext context, String sourceUuid, String targ
                                     targetProperties.get(versionPropertyName)));
                             }
                         }
-                        Blob targetblob = jCloudConfiguration.getClient().getBlobStore().blobBuilder(targetBlobName)
-                            .payload(sourceBlob.getPayload())
-                            .contentLength(sourceBlob.getMetadata().getContentMetadata().getContentLength())
-                            .userMetadata(targetProperties)
-                            .build();
-
-                        // Upload the Blob in multiple chunks to supports large files.
-                        jCloudConfiguration.getClient().getBlobStore().putBlob(jCloudConfiguration.getContainerName(), targetblob, multipart());
+
+                        // Use the copyBlob to copy the resource with updated metadata.
+                        jCloudConfiguration.getClient().getBlobStore().copyBlob(
+                            jCloudConfiguration.getContainerName(),
+                            sourceBlobName,
+                            jCloudConfiguration.getContainerName(),
+                            targetBlobName,
+                            CopyOptions.builder().userMetadata(targetProperties).build());
                     }
                 }
                 marker = page.getNextMarker();