Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using gn- icon definitions for all types in metadata creation #7721

Conversation

joachimnielandt
Copy link
Collaborator

Made use of the global .less definitions for the various record type icons, instead of the hardcoded fa- icons. We make use of series in our fork as well, I guess it won't hurt to include it here as well for futureproofing?

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@fxprunayre fxprunayre added this to the 4.4.3 milestone Feb 8, 2024
@fxprunayre fxprunayre merged commit 590211c into geonetwork:main Feb 8, 2024
6 checks passed
@joachimnielandt joachimnielandt deleted the corepr/create-metadata-icons branch February 8, 2024 11:50
joachimnielandt pushed a commit to Informatievlaanderen/metadata-geonetwork that referenced this pull request Mar 6, 2024
Including core PR for the icons: geonetwork#7721

Related work items: #186308, #186607, #186834, #186852, #186860, #187182, #187183, #187213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants