-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional metadata processing when publishing / un-publishing metadata. #7747
Support additional metadata processing when publishing / un-publishing metadata. #7747
Conversation
63cfe2e
to
fffd513
Compare
It seems odd to create a new interface This would remove all the And then if someone wants to add functionality for public class CustomPublicationConfig extends DefaultPublicationConfig |
@ianwallen the idea was to avoid the processing of the metadata in batch publication, even if the method does nothing, but I can update the code with your suggestions. |
…nAction interface. Fix the batch sharing report not filling the metadata processed list
156ae54
to
a73041f
Compare
@ianwallen I've updated the code from your suggestions, updating the method to accept the metadata identifier, so doesn't need to be retrieved in advance the metadata instance, specially for batch processing. Also fixed the batch sharing report not filling properly the list of metadata processed. |
services/src/main/java/org/fao/geonet/config/IPublicationConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to work as expected.
Follow up of #7148
The change adds a method
processMetadata
with an empty implementation to theIPublicationConfig
interface that can be implemented by a custom publication configuration to execute additional processing on the metadata published / unpublished, for example to assign / remove a category:The default publication configuration (https://github.com/geonetwork/core-geonetwork/blob/main/services/src/main/java/org/fao/geonet/config/DefaultPublicationConfig.java) is not changed.
Also adds a class name in the user interface to facilitate the styling of the publication options in the
Manage record
menu.Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation