-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static page for record view menu #7802
base: main
Are you sure you want to change the base?
static page for record view menu #7802
Conversation
web-ui/src/main/resources/catalog/components/search/mdview/mdviewModule.js
Outdated
Show resolved
Hide resolved
gnGlobalSettings.gnCfg.mods[configKey][$scope.section + "CustomMenu"]; | ||
|
||
if ($scope.pagesConfig && $scope.pagesConfig.length === 0) { | ||
if ($scope.section === "header" || $scope.section === "footer") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the reason for this change. Can you explain why the original code require to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was hardcoded to either header or footer in the previous version. I am just trying to keep the old logic in place. But if you think we should get rid of it to simplify. Let me know
@@ -104,6 +104,16 @@ | |||
$scope.showStatusTopBarFor = | |||
gnGlobalSettings.gnCfg.mods.recordview.showStatusTopBarFor; | |||
|
|||
$scope.showStaticPageMenu = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need an extra setting for this. I mean if the user creates entries with the new menu option, why not show them always instead of adding an extra UI option? What do you think @fxprunayre?
…iewModule.js Co-authored-by: Jose García <[email protected]>
|
Introduce static page to metadata record view menu. Here is the feature introduction.
The user can select such option when you add/edit such static page.
Then enable the Additional Links from UI Setting for the static pages
Then this additional link drop down contains static pages will show on the record view menu list