Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static page for record view menu #7802

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wangf1122
Copy link
Collaborator

@wangf1122 wangf1122 commented Feb 23, 2024

Introduce static page to metadata record view menu. Here is the feature introduction.

The user can select such option when you add/edit such static page.

image

Then enable the Additional Links from UI Setting for the static pages

image

Then this additional link drop down contains static pages will show on the record view menu list

image

@wangf1122 wangf1122 marked this pull request as ready for review February 23, 2024 22:17
@wangf1122 wangf1122 marked this pull request as draft February 26, 2024 20:55
@wangf1122 wangf1122 marked this pull request as ready for review March 1, 2024 17:49
gnGlobalSettings.gnCfg.mods[configKey][$scope.section + "CustomMenu"];

if ($scope.pagesConfig && $scope.pagesConfig.length === 0) {
if ($scope.section === "header" || $scope.section === "footer") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the reason for this change. Can you explain why the original code require to be updated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was hardcoded to either header or footer in the previous version. I am just trying to keep the old logic in place. But if you think we should get rid of it to simplify. Let me know

@@ -104,6 +104,16 @@
$scope.showStatusTopBarFor =
gnGlobalSettings.gnCfg.mods.recordview.showStatusTopBarFor;

$scope.showStaticPageMenu =
Copy link
Member

@josegar74 josegar74 Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need an extra setting for this. I mean if the user creates entries with the new menu option, why not show them always instead of adding an extra UI option? What do you think @fxprunayre?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants