Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OGC API coverages subset and datetime not forwarded #967

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

fmigneault
Copy link
Member

Fixes needed for OGC TB-20 TIEs.

Some parameters are not forwarded to the coverage endpoint, causing requests to be refused by servers that consider the subset to be too large to return reasonably.

@geographika
Copy link
Contributor

@fmigneault @tomkralidis - the failing test is due to making an external request in the offline testing. Adding the decorator @pytest.mark.online to test_ogcapi_build_url should fix this:

def test_ogcapi_build_url(path, expected):

It looks like creating any OGC API class will make an HTTP directly on __init__ - I think this differs from WMS/WFS where the class can be created and then HTTP requests made with a different call.

response = http_get(self.url, headers=self.headers, auth=self.auth).json()

@tomkralidis
Copy link
Member

@fmigneault @tomkralidis - the failing test is due to making an external request in the offline testing. Adding the decorator @pytest.mark.online to test_ogcapi_build_url should fix this:

def test_ogcapi_build_url(path, expected):

+1

It looks like creating any OGC API class will make an HTTP directly on __init__ - I think this differs from WMS/WFS where the class can be created and then HTTP requests made with a different call.

response = http_get(self.url, headers=self.headers, auth=self.auth).json()

Not sure. WMS support always does a GetCapabilities on init.

@fmigneault
Copy link
Member Author

I've added more tests (all passed) for the various kw updates related to OGC API coverages.
Failing tests are unrelated to this PR (records and csw tests).

@tomkralidis tomkralidis merged commit 555b785 into geopython:master Jan 21, 2025
3 checks passed
@fmigneault
Copy link
Member Author

@tomkralidis
Thanks for merging.
Are there plans for a new release in a near future?

@fmigneault fmigneault deleted the fix-coverage-subset branch January 21, 2025 15:45
@tomkralidis
Copy link
Member

tomkralidis commented Jan 21, 2025

@tomkralidis Thanks for merging. Are there plans for a new release in a near future?

Probably a good time for 0.31.1 0.32.1 then (@geographika thoughts?).

@geographika
Copy link
Contributor

@tomkralidis @fmigneault - yes, I can make a new release this week. There are quite a few changes, but all appear so far to be bug fixes, so it would be 0.32.1 - although if #963 is merged I think it would bump it to 0.33.0 as it is a change in functionality.

@tomkralidis
Copy link
Member

@tomkralidis @fmigneault - yes, I can make a new release this week. There are quite a few changes, but all appear so far to be bug fixes, so it would be 0.32.1 - although if #963 is merged I think it would bump it to 0.33.0 as it is a change in functionality.

Sorry, typo, yes 0.32.1.

@fmigneault
Copy link
Member Author

Hi @geographika
Doing a follow-up about this. The other PR doesn't seem to be receiving the requested feedback. Is it being worked on or should this be released separately?
Thanks

@geographika
Copy link
Contributor

@fmigneault - no #963 not yet merged, but this pull request has been released in https://github.com/geopython/OWSLib/releases/tag/0.32.1 and is available at https://pypi.org/project/OWSLib/
You should have got a ping from the release as you're tagged (and also posted to the mailing lists https://lists.osgeo.org/mailman/listinfo/owslib-users and https://lists.osgeo.org/mailman/listinfo/owslib-devel).

@fmigneault
Copy link
Member Author

@geographika Thanks

fmigneault added a commit to crim-ca/weaver that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants